[Kirkstone] Backport of CAN interrupt pin patch #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current configuration hard-code the values of the CAN interrupt pins. This setting allows to change them. The default values are the same as before. Signed-off-by: Damiano Ferrari <[email protected]>
dferrarigrowtech
force-pushed
the
kirkstone
branch
from
cfd5c68 to
a93a444
Compare
|
I don't know if I should also cherry pick the commit about the documentation. I tried but the CI failed, so I removed that commit. Waiting for instructions |
|
I would pull in the documentation as well. |
Signed-off-by: Damiano Ferrari <[email protected]>
|
Thank you @agherzan, now I think we are ready for the CI to start |
agherzan
approved these changes
Feb 8, 2024
|
@agherzan all the checks have passed except the docs one. I noticed that check was not passed even before I added the docs commit. What could it be? Can we merge this anyway? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cherry picking of the commit merged yesterday about CAN interrupt pins.
Original PR: